DasPoschi/jd-jellyfin-stack
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix md5 directory permissions fallback #2

Closed
DasPoschi wants to merge 1 commits from codex/analyze-and-fix-issue into main
pull from: codex/analyze-and-fix-issue
merge into: DasPoschi:main
Conversation 0 Commits 1 Files Changed 1 +28 -2
DasPoschi commented 2025-12-31 17:53:58 +00:00 (Migrated from github.com)
Copy Link

Motivation

  • Schreibfehler beim Anlegen der MD5-Seitendateien vermeiden, wenn MD5_DIR nicht beschreibbar ist.
  • Sicherstellen, dass ein beschreibbarer Speicherort gefunden wird, auch wenn der Container-Standard (/md5) keine Schreibrechte hat.
  • Bevorzugen der konfigurierten MD5_DIR, ansonsten Fallback auf /output/.md5 oder /tmp/jd-md5.

Description

  • Added a cached variable _md5_dir_cache and a helper pick_md5_dir() that selects a writable MD5 directory from candidates.
  • pick_md5_dir() tries MD5_DIR, os.path.join(JD_OUTPUT_PATH, ".md5") and /tmp/jd-md5, creating directories and checking write access.
  • Updated write_md5_sidecar() to use pick_md5_dir() and write the .md5 file into the selected directory.
  • Raises a clear RuntimeError in German when no writable MD5 directory can be found.

Testing

  • Keine automatisierten Tests wurden ausgeführt.

Codex Task

### Motivation - Schreibfehler beim Anlegen der MD5-Seitendateien vermeiden, wenn `MD5_DIR` nicht beschreibbar ist. - Sicherstellen, dass ein beschreibbarer Speicherort gefunden wird, auch wenn der Container-Standard (`/md5`) keine Schreibrechte hat. - Bevorzugen der konfigurierten `MD5_DIR`, ansonsten Fallback auf ` /output/.md5` oder `/tmp/jd-md5`. ### Description - Added a cached variable `_md5_dir_cache` and a helper `pick_md5_dir()` that selects a writable MD5 directory from candidates. - `pick_md5_dir()` tries `MD5_DIR`, `os.path.join(JD_OUTPUT_PATH, ".md5")` and `/tmp/jd-md5`, creating directories and checking write access. - Updated `write_md5_sidecar()` to use `pick_md5_dir()` and write the `.md5` file into the selected directory. - Raises a clear `RuntimeError` in German when no writable MD5 directory can be found. ### Testing - Keine automatisierten Tests wurden ausgeführt. ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_69556276187c8327aa89ad7e7569b67d)
👍 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 codex
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label codex
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DasPoschi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DasPoschi/jd-jellyfin-stack#2
Delete Branch "codex/analyze-and-fix-issue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?