fix(sidebar): drop the dead WebUI count path

This commit is contained in:
Rod Boev
2026-06-12 11:55:43 -04:00
parent 66a2d577df
commit 0ed902bd05
3 changed files with 3 additions and 5 deletions

View File

@@ -4728,7 +4728,6 @@ function _sidebarRowHasVisibleMessages(s, activeSidForSidebar){
}
function _partitionSidebarSessionRows(allMatched, activeSidForSidebar){
let webuiSessionCount=0;
let cliSessionCount=0;
const webuiProfileFiltered=[];
const cliProfileFiltered=[];
@@ -4740,7 +4739,6 @@ function _partitionSidebarSessionRows(allMatched, activeSidForSidebar){
if(!_sidebarRowHasVisibleMessages(s, activeSidForSidebar)) continue;
const isCli=_isCliSession(s);
if(isCli) cliSessionCount++;
else webuiSessionCount++;
if(s.default_hidden&&!(_activeProject&&_activeProject!==NO_PROJECT_FILTER&&s.project_id===_activeProject)) continue;
const profileFiltered=isCli ? cliProfileFiltered : webuiProfileFiltered;
const sessionsRaw=isCli ? cliSessionsRaw : webuiSessionsRaw;
@@ -4762,7 +4760,6 @@ function _partitionSidebarSessionRows(allMatched, activeSidForSidebar){
}
const showCliOnly=_sessionSourceFilter==='cli';
return {
webuiSessionCount,
cliSessionCount,
profileFiltered: showCliOnly ? cliProfileFiltered : webuiProfileFiltered,
sessionsRaw: showCliOnly ? cliSessionsRaw : webuiSessionsRaw,

View File

@@ -19,11 +19,12 @@ def test_sidebar_has_separate_webui_and_cli_session_source_tabs():
def test_cli_filter_keeps_cli_rows_out_of_default_webui_list():
src = SESSIONS_JS.read_text(encoding="utf-8")
assert "function _partitionSidebarSessionRows(allMatched, activeSidForSidebar)" in src
assert "webuiSessionCount" in src
assert "cliSessionCount" in src
assert "const showCliOnly=_sessionSourceFilter==='cli';" in src
assert "const webuiProfileFiltered=[];" in src
assert "const cliProfileFiltered=[];" in src
assert "const webuiSessionsRaw=[];" in src
assert "const cliSessionsRaw=[];" in src
assert "profileFiltered: showCliOnly ? cliProfileFiltered : webuiProfileFiltered," in src
assert "sessionsRaw: showCliOnly ? cliSessionsRaw : webuiSessionsRaw," in src

View File

@@ -58,7 +58,7 @@ def test_partition_helper_applies_message_source_project_and_archive_gates():
def test_partition_helper_keeps_raw_source_counts_while_render_owns_visible_counts():
render_body = _function_block("renderSessionListFromCache")
assert "webuiSessionCount," in _partition_block()
assert "webuiSessionCount," not in _partition_block()
assert "cliSessionCount," in _partition_block()
assert "webuiSessionsRaw," in _partition_block()
assert "cliSessionsRaw," in _partition_block()