67193faf38
Three small fixes from Opus review of the merged stage diff: 1. Strip 9 orphan wiki_* i18n keys (72 lines) from PR #1342 — leaked from a different branch, zero references outside i18n.js. 2. /branch endpoint: reject non-string session_id with explicit 400 (was raising TypeError → generic 500 from get_session()). 3. /branch endpoint: reject negative keep_count with explicit 400 (Python slice semantics on negative produces 'all but last N', confusing fork behavior). Plus tests/test_v050253_opus_followups.py — 3 regression tests pinning all three fixes. Verified: 3558 pytest passing.
91 lines
4.0 KiB
Python
91 lines
4.0 KiB
Python
"""Regression tests for v0.50.253 Opus pre-release follow-ups.
|
|
|
|
Three small follow-ups landed alongside the main batch:
|
|
|
|
1. /branch endpoint rejects non-string session_id with a 400 (instead of
|
|
crashing with a generic 500 from get_session() raising TypeError).
|
|
2. /branch endpoint rejects negative keep_count (Python slicing semantics
|
|
would otherwise produce "all but last N" rather than a forward prefix).
|
|
3. PR #1342 leaked 9 unused `wiki_*` i18n keys from a different branch.
|
|
These were stripped — assert they don't come back.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
REPO = Path(__file__).resolve().parents[1]
|
|
|
|
|
|
# ── 1 + 2: /branch endpoint validation ────────────────────────────────────────
|
|
|
|
|
|
def test_branch_endpoint_rejects_non_string_session_id():
|
|
"""The handler must reject a non-string session_id with a 400 before
|
|
reaching get_session()."""
|
|
src = (REPO / "api" / "routes.py").read_text(encoding="utf-8")
|
|
branch_handler_idx = src.find('parsed.path == "/api/session/branch":')
|
|
assert branch_handler_idx != -1, "branch handler not found"
|
|
# Look at the next ~1500 chars
|
|
block = src[branch_handler_idx : branch_handler_idx + 1500]
|
|
assert 'isinstance(body["session_id"], str)' in block, (
|
|
"branch handler must isinstance-check session_id before passing to "
|
|
"get_session() — without this, non-string values raise TypeError "
|
|
"and surface as a confusing 500 instead of a 400."
|
|
)
|
|
assert '"session_id must be a string"' in block, (
|
|
"branch handler must return a clear error message for non-string "
|
|
"session_id, not a generic bad-request."
|
|
)
|
|
|
|
|
|
def test_branch_endpoint_rejects_negative_keep_count():
|
|
"""The handler must reject keep_count < 0 with a 400. Otherwise Python
|
|
slicing would produce a "all but last N" semantic instead of a forward
|
|
prefix, which is confusing fork behavior."""
|
|
src = (REPO / "api" / "routes.py").read_text(encoding="utf-8")
|
|
branch_handler_idx = src.find('parsed.path == "/api/session/branch":')
|
|
block = src[branch_handler_idx : branch_handler_idx + 2000]
|
|
assert "keep_count < 0" in block, (
|
|
"branch handler must reject negative keep_count — Python's slice "
|
|
"semantics on negative values are 'all but last N', not 'prefix N', "
|
|
"and that's a confusing fork behavior."
|
|
)
|
|
assert '"keep_count must be non-negative"' in block, (
|
|
"branch handler must return a clear error message for negative "
|
|
"keep_count."
|
|
)
|
|
|
|
|
|
# ── 3: orphan wiki_* i18n keys must not return ────────────────────────────────
|
|
|
|
|
|
def test_no_orphan_wiki_i18n_keys():
|
|
"""PR #1342 leaked 9 unused `wiki_*` keys (wiki_panel_title, wiki_status_label,
|
|
wiki_entry_count, wiki_last_modified, wiki_not_available, wiki_enabled,
|
|
wiki_disabled, wiki_toggle_failed, wiki_panel_desc) into static/i18n.js
|
|
from a different branch. Zero references existed outside i18n.js. They
|
|
were stripped by Opus pre-release follow-up. This test pins that they
|
|
don't return."""
|
|
i18n_src = (REPO / "static" / "i18n.js").read_text(encoding="utf-8")
|
|
# If wiki_* keys are added in the future, they MUST have at least one
|
|
# reference outside i18n.js. Until then, this test fails loudly.
|
|
forbidden_keys = [
|
|
"wiki_panel_title",
|
|
"wiki_panel_desc",
|
|
"wiki_status_label",
|
|
"wiki_entry_count",
|
|
"wiki_last_modified",
|
|
"wiki_not_available",
|
|
"wiki_enabled",
|
|
"wiki_disabled",
|
|
"wiki_toggle_failed",
|
|
]
|
|
for key in forbidden_keys:
|
|
assert key not in i18n_src, (
|
|
f"{key!r} is back in static/i18n.js but no consumer uses it. "
|
|
"If you're adding wiki UI, also wire it up in the JS / panel HTML / "
|
|
"Python so the key is actually used. See v0.50.253 Opus pre-release "
|
|
"review."
|
|
)
|