Some checks failed
Release & Docker / release (push) Has been cancelled
* Harden interrupted recovery control filtering * Redesign live-to-final assistant replies * Fix live activity anchor test fixture * Fix CI lint issues for live reply tests * Strengthen live progress prompt contract * Recover PR #3401 refresh on origin/master * Repair live-to-final refresh regressions * Fix live worklog refresh regressions * Show live footer timer on initial stream start * Restore live stream shell after reload * Preserve per-frame live SSE replay cursors * Preserve reasoning as Worklog Thinking cards * Quiet Worklog Thinking card styling * Align Worklog Thinking card styling * Scope live Worklog Thinking cards by segment * Suppress exact duplicate settled Thinking * Close #3401 merge review test gaps * fix(#3401): resolve 4 deep-review regressions (inline-think, reconnect-dup, neon skin, busy-gate worklog) Deep review (Codex diff-vs-master + live-browser drive) of the live-to-final refactor surfaced 4 regressions vs master that the rewritten suite no longer guarded: 1. Inline <think>…</think>answer reasoning vanished — _assistantReasoningPayloadText used $-anchored regexes so a leading think block + visible answer extracted nothing and the Thinking card never rendered. Removed the 3 $ anchors to match the (non-anchored) display stripper. Live: inline-think thinking-only turn now renders. 2. (CORE) reconnect/reload duplicated the live reply — _rememberRunJournalCursor advanced a closure-local seq but never wrote INFLIGHT[activeSid].lastRunJournalSeq, so a reload replayed the journal from after_seq=0 over restored lastAssistantText. Now mirrors the cursor onto INFLIGHT + schedules a throttled persist. 3. Neon skin silently broke — PR deleted the :root[data-skin="neon"] CSS but left Neon in the picker. Restored the neon CSS block from master. 4. Settled tool-worklog rebuild gated purely on !S.busy — dropped every prior settled turn's worklog when renderMessages re-ran during an active stream (switch-back to an in-progress session). Restored master's !S.busy || (S.toolCalls && S.toolCalls.length). Live: busy re-render now preserves tool cards (4→4, was 4→0). Live-verified all 4 + confirmed #3709/#3592 invariants still hold (1 thinking card, none below footer; distinct siblings preserved). + tests/test_issue3401_deep_review_fixes.py (7). * test(#3401): realign 3 stale source-shape assertions to the deep-review fixes Fix commit changed two source literals that existing stage tests scanned for: - test_live_activity_timeline.py (x2): split anchor 'if(!S.busy){' → the restored 'if(!S.busy || (S.toolCalls&&S.toolCalls.length)){' guard (fix 4). - test_run_journal_frontend_static.py: 'after_seq=0' not in source — fix 2's comment contained that literal; rephrased the comment to 'the zero floor (after_seq of 0)'. Intent of all three assertions unchanged; only the matched string updated. No code behavior change. * docs(changelog): v0.51.294 — Release JJ (stage-3401, #3401 live-to-final redesign) --------- Co-authored-by: Frank Song <franksong2702@gmail.com> Co-authored-by: Nathan-Hermes <nesquena-hermes@users.noreply.github.com> Co-authored-by: nesquena-hermes <[email protected]>
74 lines
3.6 KiB
Python
74 lines
3.6 KiB
Python
import pathlib
|
|
import re
|
|
|
|
|
|
STYLE_CSS = (pathlib.Path(__file__).parent.parent / "static" / "style.css").read_text(encoding="utf-8")
|
|
UI_JS = (pathlib.Path(__file__).parent.parent / "static" / "ui.js").read_text(encoding="utf-8")
|
|
COMPACT_CSS = re.sub(r"\s+", "", STYLE_CSS)
|
|
|
|
|
|
def test_tool_card_toggle_uses_transformable_layout_and_transition():
|
|
assert ".tool-card-toggle,.tl-caret{" in COMPACT_CSS
|
|
assert "display:inline-flex" in COMPACT_CSS
|
|
assert "transition:transform.18sease" in COMPACT_CSS
|
|
|
|
|
|
def test_tool_card_detail_uses_transitionable_collapsed_state():
|
|
assert ".tool-card-detail,.tl-detail{display:block;max-height:0;opacity:0;overflow:hidden;" in COMPACT_CSS
|
|
assert re.search(
|
|
r"\.tool-card\.open\s+\.tool-card-detail,\s*\.tl\.open\s+\.tl-detail\s*\{[^}]*max-height:\s*320px;[^}]*opacity:\s*1;",
|
|
STYLE_CSS,
|
|
)
|
|
# Open state must set overflow to auto so the inner <pre> scroll is not clipped (#1170).
|
|
assert re.search(
|
|
r"\.tool-card\.open\s+\.tool-card-detail,\s*\.tl\.open\s+\.tl-detail\s*\{[^}]*overflow:\s*auto;",
|
|
STYLE_CSS,
|
|
)
|
|
|
|
|
|
def test_thinking_card_toggle_and_body_use_animation_friendly_state():
|
|
assert ".thinking-card-btn-row{margin-left:auto;display:inline-flex;align-items:center;gap:6px;" in COMPACT_CSS
|
|
assert ".thinking-card-toggle{font-size:10px;display:inline-flex;" in COMPACT_CSS
|
|
assert ".thinking-card-header{display:flex;align-items:center;gap:8px;" in COMPACT_CSS
|
|
# Body uses div default (display:block); canonical rule lives in the
|
|
# consolidated block. Open state caps at 260px (intentional "quieter" sizing).
|
|
assert ".thinking-card-body{max-height:0;opacity:0;overflow:hidden;" in COMPACT_CSS
|
|
assert re.search(
|
|
r"\.thinking-card\.open\s+\.thinking-card-body\s*\{[^}]*max-height:\s*260px;[^}]*opacity:\s*1;",
|
|
STYLE_CSS,
|
|
)
|
|
|
|
|
|
def test_tool_card_toggle_uses_same_chevron_icon_markup_as_thinking_card():
|
|
assert "<span class=\"thinking-card-toggle\">${li('chevron-right',12)}</span>" in UI_JS
|
|
assert "<span class=\"tool-card-toggle\">${li('chevron-right',12)}</span>" in UI_JS
|
|
assert "<div class=\"${classes}\"><div class=\"thinking-card-header\" onclick=\"this.parentElement.classList.toggle('open')\"><span class=\"thinking-card-icon\">" in UI_JS
|
|
|
|
|
|
def test_thinking_card_header_includes_copy_button_that_does_not_toggle_card():
|
|
assert "function _copyThinkingText(btn){" in UI_JS
|
|
assert "const copyBtn=`<button class=\"thinking-copy-btn\"" in UI_JS
|
|
assert "event.stopPropagation();_copyThinkingText(this)" in UI_JS
|
|
assert "card.querySelector('.thinking-card-body pre')" in UI_JS
|
|
assert "_copyText(text).then(()=>{" in UI_JS
|
|
assert "btn.innerHTML=li('check',12);" in UI_JS
|
|
assert ".thinking-copy-btn{" in COMPACT_CSS
|
|
assert ".thinking-copy-btn:hover,.thinking-copy-btn:focus-visible{" in COMPACT_CSS
|
|
|
|
|
|
def test_live_thinking_updates_existing_card_body_in_place():
|
|
assert "function _renderThinkingInto(row,text='')" in UI_JS
|
|
assert "row.querySelector('.thinking-card-body pre')" in UI_JS
|
|
assert "pre.textContent=clean" in UI_JS
|
|
assert "_renderThinkingInto(row,text);" in UI_JS
|
|
|
|
|
|
def test_thinking_card_uses_panel_chrome_with_gold_palette():
|
|
# Canonical thinking-card rule lives in the consolidated block (border-radius
|
|
# tightened from 10px → 8px as part of the "quieter card" design pass).
|
|
assert re.search(
|
|
r"\.thinking-card\s*\{[^}]*background:\s*var\(--accent-bg\);[^}]*border:\s*1px\s+solid\s+var\(--accent-bg-strong\);[^}]*border-radius:\s*8px;",
|
|
STYLE_CSS,
|
|
)
|
|
assert "border-left: 2px solid rgba(201,168,76,.4);" not in STYLE_CSS
|