4cf40a317a
Some checks failed
Release & Docker / release (push) Has been cancelled
## Release v0.51.264 — Release IF (stage-r14) Un-held sibling pair (#3585 + #3586) — both addressed the findings from the earlier hold; re-reviewed fresh. ### Fixed | Issue/PR | Author | Fix | |----------|--------|-----| | #3585 | @rodboev | Cron sessions no longer flood the CLI sidebar window (restored the `("cron","webui")` exclusion in `_load_cli_sessions_uncached`). | | #3586 | @rodboev | Messaging sessions keep their source label after a refresh **and open + send correctly** — `is_cli_session_row()` classifies them non-CLI, and the sidebar open/import path now uses `_isMessagingSession()` so a reclassified Discord/Telegram/Slack row is imported on open (no transient stub → no `/api/chat/start` 404). | ### Un-hold note These were held earlier today because the `is_cli_session_row()` reclassification (#3586) created a CORE open-path regression — opening a reclassified messaging session 404'd on the next send. The author pushed a fix adding the `_isMessagingSession()` import gate at all open/lineage/refresh paths (+ regression test `test_issue3603_external_session_import_gate.py`), and Codex confirmed both that AND the secondary webui-recovery concern (cron-only exclusion now keeps `source='webui'` sidecar-less recovery rows) are resolved. ### Gate - Full pytest suite: **7729 passed, 0 failed** - ESLint: CLEAN · ruff: CLEAN · browser-smoke: CLEAN - Codex (regression): **SAFE TO SHIP** — open→import→send path verified (messaging rows go through `/api/session/import_cli` before `/api/chat/start`); `is_cli_session_row` classification correct; the pair composes in `_load_cli_sessions_uncached`. Co-authored-by: rodboev <rodboev@users.noreply.github.com>
85 lines
3.0 KiB
Python
85 lines
3.0 KiB
Python
"""Regression test for _isExternalSession helper covering messaging open-path (#3603).
|
|
|
|
After #3603 reclassified messaging sessions (Discord/Telegram/Slack) as
|
|
non-CLI, the session open path only triggered import_cli for `is_cli_session`
|
|
sessions, making messaging sessions click-to-open-but-can't-send.
|
|
|
|
This test pins:
|
|
- `_isExternalSession` exists in sessions.js
|
|
- The open-path gate at line ~5024 uses `_isExternalSession` (not just is_cli_session)
|
|
- The gateway-refresh gate at line ~3116 uses `_isExternalSession`
|
|
- The lineage-segment and child-session open gates use `_isExternalSession`
|
|
"""
|
|
|
|
import re
|
|
|
|
|
|
def _read_js():
|
|
with open('static/sessions.js', encoding='utf-8') as f:
|
|
return f.read()
|
|
|
|
|
|
def test_is_external_session_function_exists():
|
|
"""sessions.js must define _isExternalSession helper."""
|
|
js = _read_js()
|
|
assert re.search(r'function\s+_isExternalSession\s*\(', js), (
|
|
'_isExternalSession function not found in sessions.js'
|
|
)
|
|
|
|
|
|
def test_is_external_session_covers_messaging():
|
|
"""_isExternalSession must check both is_cli_session and _isMessagingSession."""
|
|
js = _read_js()
|
|
m = re.search(
|
|
r'function\s+_isExternalSession\s*\([^)]*\)\s*\{([^}]*)\}',
|
|
js,
|
|
re.DOTALL,
|
|
)
|
|
assert m, '_isExternalSession function body not found'
|
|
body = m.group(1)
|
|
assert 'is_cli_session' in body, (
|
|
'_isExternalSession must reference is_cli_session'
|
|
)
|
|
assert '_isMessagingSession' in body, (
|
|
'_isExternalSession must reference _isMessagingSession'
|
|
)
|
|
|
|
|
|
def test_open_path_uses_is_external_session():
|
|
"""Session open handler must use _isExternalSession for import gate."""
|
|
js = _read_js()
|
|
# The import gate in the session-click handler should use _isExternalSession
|
|
assert re.search(
|
|
r'if\s*\(\s*_isExternalSession\s*\(\s*s\s*\)\s*\)',
|
|
js,
|
|
), 'Session open handler must use _isExternalSession(s) for import gate'
|
|
|
|
|
|
def test_gateway_refresh_uses_is_external_session():
|
|
"""Gateway SSE refresh must use _isExternalSession for active-session check."""
|
|
js = _read_js()
|
|
# Find the gateway SSE handler block (near line 3116)
|
|
# It should have _isExternalSession(S.session)
|
|
assert re.search(
|
|
r'if\s*\(\s*S\.session\s*&&\s*!S\.busy\s*&&\s*_isExternalSession\s*\(\s*S\.session\s*\)\s*\)',
|
|
js,
|
|
), 'Gateway SSE refresh must use _isExternalSession(S.session)'
|
|
|
|
|
|
def test_lineage_open_uses_is_external_session():
|
|
"""Lineage segment open handler must use _isExternalSession."""
|
|
js = _read_js()
|
|
assert re.search(
|
|
r'if\s*\(\s*_isExternalSession\s*\(\s*seg\s*\)\s*\)',
|
|
js,
|
|
), 'Lineage segment open must use _isExternalSession(seg)'
|
|
|
|
|
|
def test_child_session_open_uses_is_external_session():
|
|
"""Child session open handler must use _isExternalSession."""
|
|
js = _read_js()
|
|
assert re.search(
|
|
r'if\s*\(\s*_isExternalSession\s*\(\s*child\s*\)\s*\)',
|
|
js,
|
|
), 'Child session open must use _isExternalSession(child)'
|