DasPoschi/hermes-webui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#4006): defensive !==false at the 2 remaining settings-hydration sites (Opus note)

Browse Source 
panels.js _autosaveAppearanceSettings (6309) + _applySavedSettingsUi (7837) read
auto_scroll_follow from a settings/body object — use !==false (default True) for
consistency with boot.js + the checkbox render, so a future partial-body refactor
can't silently default the True setting OFF. The .checked reads (6223/8170) keep !!
(a real bool).
This commit is contained in:
nesquena-hermes
2026-06-13 04:27:01 +00:00
parent 9f6ed5a61b
commit f5fb50983b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/panels.js
View File

@@ -6306,7 +6306,7 @@ async function _autosaveAppearanceSettings(payload){
if(typeof _applySessionNavigationPrefs==='function') _applySessionNavigationPrefs();
}
window._sessionEndlessScrollEnabled=!!(saved&&saved.session_endless_scroll);
window._autoScrollFollow=!!(saved&&saved.auto_scroll_follow);
window._autoScrollFollow=!saved||saved.auto_scroll_follow!==false;
if(saved&&payload&&Object.prototype.hasOwnProperty.call(payload,'worklog_details_expanded_default')&&(
Object.prototype.hasOwnProperty.call(saved,'worklog_details_expanded_default') ||
Object.prototype.hasOwnProperty.call(saved,'activity_feed_expanded_default')
@@ -7834,7 +7834,7 @@ function _applySavedSettingsUi(saved, body, opts){
window._sidebarDensity=sidebarDensity==='detailed'?'detailed':'compact';
window._busyInputMode=body.busy_input_mode||'queue';
window._sessionEndlessScrollEnabled=!!body.session_endless_scroll;
window._autoScrollFollow=!!body.auto_scroll_follow;
window._autoScrollFollow=body.auto_scroll_follow!==false;
window._botName=body.bot_name||'Hermes';
if(typeof applyBotName==='function') applyBotName();
if(typeof setLocale==='function') setLocale(language);